Re: [PATCH 2/2] rust: alloc: cleanup doctest imports to "kernel vertical" style
From: Danilo Krummrich
Date: Tue May 12 2026 - 11:22:59 EST
On Tue May 12, 2026 at 4:11 PM CEST, Gary Guo wrote:
> On Mon May 11, 2026 at 10:41 PM BST, Danilo Krummrich wrote:
>> @@ -174,8 +174,11 @@ impl Vmalloc {
>> /// # Examples
>> ///
>> /// ```
>> - /// # use core::ptr::{NonNull, from_mut};
>> - /// # use kernel::{page, prelude::*};
>> + /// # use core::ptr::{
>> + /// # from_mut,
>> + /// # NonNull, //
>> + /// # };
>
> I thought the consensus was that hidden lines don't need to use vertical import
> style.
Don't need to, but still can; I generally prefer to keep it consistent.
We can drop the - for doc-comments - unnecessary '//' though, which my muscle
memory inserted regardless. :)