Re: [PATCH v2 07/10] iio: light: opt3001: prefer dev_err_probe()

[Andy Shevchenko]

On Tue, May 12, 2026 at 12:57:27PM +0200, Joshua Crofts via B4 Relay wrote:

> Switch driver to use dev_err_probe() to unify
> error messages generated in *_probe() and probe path functions.

These lines are not balanced in length...


...

> -		return dev_err(dev, "failed to register IIO device\n");
> +		return dev_err_probe(dev, ret,
> +				     "failed to register IIO device\n");


I believe a single line in this and similar cases is fine

		return dev_err_probe(dev, ret, "failed to register IIO device\n");

(it's only 82 characters).

-- 
With Best Regards,
Andy Shevchenko