Re: [PATCH v6] HID: magicmouse: add battery reporting for Magic Trackpad v1

[Jiri Kosina]

On Thu, 16 Apr 2026, Damiano Gragnaniello wrote:

[ ... snip ... ]
>  
> -	/* If there is only one "firm" touch, set touch to its
> -	 * tracking ID.
> -	 */
[ ... snip ... ]
> -		/* If some button was pressed before, keep it held
> -		 * down.  Otherwise, if there's exactly one firm
> -		 * touch, use that to override the mouse's guess.
> -		 */
[ ... snip ... ]
> -	/* If requested, emulate a scroll wheel by detecting small
> -	 * vertical touch motions.
> -	 */
> -	if (emulate_scroll_wheel && (input->id.product !=
> -			USB_DEVICE_ID_APPLE_MAGICTRACKPAD2)) {
[ ... snip ... ]
> -			/* Reset acceleration after half a second. */
[ ... snip ... ]
> -	/* Generate the input events for this touch. */
[ ... snip ... ]
> -		/* Expect four bytes of prefix, and N*9 bytes of touch data. */
[ ... snip ... ]
> -		/* The following bits provide a device specific timestamp. They
> -		 * are unused here.
> -		 *
> -		 * ts = data[1] >> 6 | data[2] << 2 | data[3] << 10;
> -		 */
[ ... snip ... ]
> -		/* Expect twelve bytes of prefix and N*9 bytes of touch data. */
[ ... snip ... ]

Why are you removing all those comments? (and quite some more).

I don't think your patch changes any of this.

Thanks,

-- 
Jiri Kosina
SUSE Labs