Re: [PATCH 5/8] i3c: dw: Drop redundant Hot-Join cancel_work_sync() in shutdown

[Frank Li]

On Tue, May 12, 2026 at 03:17:29PM +0300, Adrian Hunter wrote:
> The I3C core now installs an i3c_bus_type shutdown callback that
> flushes master->hj_work (via i3c_master_shutdown()) before any driver's
> platform shutdown hook runs. The explicit cancel_work_sync() in
> dw_i3c_shutdown() is therefore redundant: by the time it executes, the
> Hot-Join worker has already been cancelled, and the shutting_down gate
> makes a new worker a no-op.
>
> Remove the now-unneeded call. No functional change.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> ---
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

>  drivers/i3c/master/dw-i3c-master.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index eb9a13a73684..c7030d0cd8a6 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1793,8 +1793,6 @@ static void dw_i3c_shutdown(struct platform_device *pdev)
>  		return;
>  	}
>
> -	cancel_work_sync(&master->base.hj_work);
> -
>  	/* Disable interrupts */
>  	writel((u32)~INTR_ALL, master->regs + INTR_STATUS_EN);
>  	writel((u32)~INTR_ALL, master->regs + INTR_SIGNAL_EN);
> --
> 2.51.0
>