Re: [PATCH] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS

[Andy Shevchenko]

On Tue, May 12, 2026 at 03:40:19PM +0000, Harshit Shaw wrote:
> Replace direct device_create_file() calls with the correct
> ATTRIBUTE_GROUPS() macro. Add fbtft_groups as dev_groups in the
> driver structure so the driver core automatically adds and removes
> the sysfs attributes when a device is bound or unbound.

> Signed-off-by: Harshit Shaw <shawharshit116@xxxxxxxxx>
> ---

This is not a v2 as you read the Subject.

> v2: Use ATTRIBUTE_GROUPS() macro and add dev_groups to driver
>     structure instead of using sysfs_create_group() directly,
>     as suggested by Greg KH.

I gave you the comments in previous version, and at least some of them were
ignored. Why?

...

> +extern const struct attribute_group *fbtft_groups[];

You haven't compiled that?

-- 
With Best Regards,
Andy Shevchenko