[PATCH v2] riscv: propagate insert_resource result from add_resource

From: Thorsten Blum

Date: Tue May 12 2026 - 13:24:40 EST


Currently, add_resource() returns 1 on success, even though its callers
only check for negative values. Instead, propagate the insert_resource()
result from add_resource() to align with standard kernel return-value
conventions (0 on success, negative errno on failure).

Use %pR to print the full resource range while at it.

Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
---
Changes in v2:
- Use %pR to print the full resource range as suggested by Ben Dooks
- v1: https://lore.kernel.org/lkml/20260512124628.300360-3-thorsten.blum@xxxxxxxxx/
---
arch/riscv/kernel/setup.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
index c89cc272440b..52d1d2b8f338 100644
--- a/arch/riscv/kernel/setup.c
+++ b/arch/riscv/kernel/setup.c
@@ -71,16 +71,13 @@ static struct resource *standard_resources;
static int __init add_resource(struct resource *parent,
struct resource *res)
{
- int ret = 0;
+ int ret;

ret = insert_resource(parent, res);
- if (ret < 0) {
- pr_err("Failed to add a %s resource at %llx\n",
- res->name, (unsigned long long) res->start);
- return ret;
- }
+ if (ret < 0)
+ pr_err("Failed to add resource %s %pR\n", res->name, res);

- return 1;
+ return ret;
}

static int __init add_kernel_resources(void)