Re: [PATCH v6 4/6] media: qcom: iris: Add rotation support for encoder

[Dmitry Baryshkov]

On Fri, Nov 14, 2025 at 11:09:01AM +0800, Wangao Wang wrote:
> Add rotation control for encoder, enabling V4L2_CID_ROTATE and handling
>  90/180/270 degree rotation.

Drop space in the beginning of the line.

The commit message fails to capture, why do we need to handle the
resolution in addition to just handling the rotation property.

> 
> Reviewed-by: Dikshita Agarwal <dikshita.agarwal@xxxxxxxxxxxxxxxx>
> Co-developed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # on SM8650-HDK
> Signed-off-by: Wangao Wang <wangao.wang@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/platform/qcom/iris/iris_ctrls.c      | 34 +++++++++++++++
>  drivers/media/platform/qcom/iris/iris_ctrls.h      |  1 +
>  .../platform/qcom/iris/iris_hfi_gen2_command.c     | 41 ++++++++++++-----
>  .../platform/qcom/iris/iris_hfi_gen2_defines.h     |  9 ++++
>  .../platform/qcom/iris/iris_platform_common.h      |  1 +
>  .../media/platform/qcom/iris/iris_platform_gen2.c  | 10 +++++
>  drivers/media/platform/qcom/iris/iris_utils.c      |  6 +++
>  drivers/media/platform/qcom/iris/iris_utils.h      |  1 +
>  drivers/media/platform/qcom/iris/iris_vpu_buffer.c | 51 +++++++++++++---------
>  9 files changed, 123 insertions(+), 31 deletions(-)
> 

-- 
With best wishes
Dmitry