Re: [PATCH 0/4] Add MSI Claw HID Configuration Driver

[Derek John Clark]

On Tue, May 12, 2026 at 9:13 AM Jiri Kosina <jikos@xxxxxxxxxx> wrote:
>
> On Sun, 10 May 2026, Derek J. Clark wrote:
>
> > This series adds and HID Configuration driver for the MSI Claw line of
> > Handheld Gaming PC's. The MSI Claw HID interface provides multiple
> > features, such as the ability to switch between xinput, dinput, and a
> > desktop mode, RGB control, rumble intensity, and mapping of the rear "M"
> > keys. There are additional gamepad modes that are not included in this
> > driver as they appear to be used in assembly line testing or are
> > incomplete in the firmware. During my testing I found them to be unstable.
> >
> > The initial version of this driver was written by Denis Benato, which
> > contained the initial reverse-engineering and implementation for the
> > gamepad mode switching. This work was later expanded by Zhouwang Huang
> > to include more gamepad modes and additional features. Finally, I
> > refactored the entire driver, fixed multiple bugs, and refined the overall
> > format to conform to kernel driver best practices and style guide.
> >
> > Claude was used initially by Zhouwang Huang to quickly parse HID captures
> > during the reverse-engineering of some of the features. Since Claude had
> > already been used, as a test of its capabilities I had it implement the
> > rumble intensity attribute after I had already rewritten most of the
> > driver, which I then manually edited to fix some mistakes. I also used
> > Claude to review the driver and these patches for any mistakes and bugs.
> >
> > Assisted-by: Claude:claude-sonnet-4-6
> > Co-developed-by: Denis Benato <denis.benato@xxxxxxxxx>
> > Signed-off-by: Denis Benato <denis.benato@xxxxxxxxx>
> > Co-developed-by: Zhouwang Huang <honjow311@xxxxxxxxx>
> > Signed-off-by: Zhouwang Huang <honjow311@xxxxxxxxx>
> > Signed-off-by: Derek J. Clark <derekjohn.clark@xxxxxxxxx>
> >
> > Derek J. Clark (4):
> >   HID: hid-msi-claw: Add MSI Claw configuration driver
> >   HID: hid-msi-claw: Add M-key mapping attributes
> >   HID: hid-msi-claw: Add RGB control interface
> >   HID: hid-msi-claw: Add Rumble Intensity Attributes
>
> The driver looks reasonable, I'd just like to propose that we name it just
> hid-msi to follow the usual HID subsystem driver naming standards, so that
> it can later be extended with supporting other MSI devices.
>

Hi Jiri,
Sounds good. I'll do that when I fix the issues flagged by the bot in
v2 and I'll try to have it out some time this week.

Thanks,
Derek

Thanks
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>