Re: [PATCH v2] atomisp: replace dbg_func parameter with dynamic debug
From: Andy Shevchenko
Date: Tue May 12 2026 - 15:15:24 EST
On Tue, May 12, 2026 at 09:09:58PM +0300, Melih Emik wrote:
> The dbg_func module parameter in atomisp_v4l2.c toggles the CSS
> debug_print callback through a writable module parameter. Removing only
> the parameter drops the runtime switch that users had through sysfs.
>
> Keep the debug path available at runtime by routing CSS debug output
> through dynamic debug instead. The callback remains installed, but its
> output is controlled by the dynamic debug callsite. CSS error output
> continues to use vprintk().
>
> Remove the obsolete parameter, its global state and the unused get/set
> helpers.
Okay, this is the move to the right direction (however we leave dbg_level for
whatever it means).
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
--
With Best Regards,
Andy Shevchenko