Re: [PATCH v3] staging: greybus: audio: correct sscanf() return value check

[Alex Elder]

On 5/12/26 2:15 PM, Alexander A. Klimov wrote:
> manager_sysfs_add_store() passes 6 pointers to sscanf(),
> but required latter to return 7 which always failed the operation.
> I corrected it to 6.
>
> Fixes: 49b9137a6002 ("staging: greybus: audio: remove redundant slot 
> field")
> Signed-off-by: Alexander A. Klimov <grandmaster@xxxxxxxxxxxx>

Looks good.

Reviewed-by: Alex Elder <elder@xxxxxxxxxxxx>

> ---
>   v2: added "Fixes:" to commit message
>   v3: added all these v2/v3 lines here as requested by Greg KH
>   v3: while on it, replaced title "Greybus audio protocols drivers:" ...
>   v3: ... with "staging: greybus: audio:"
>
>   drivers/staging/greybus/audio_manager_sysfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/ 
> staging/greybus/audio_manager_sysfs.c
> index fcd518f954..ff323ca815 100644
> --- a/drivers/staging/greybus/audio_manager_sysfs.c
> +++ b/drivers/staging/greybus/audio_manager_sysfs.c
> @@ -23,7 +23,7 @@ static ssize_t manager_sysfs_add_store(struct kobject 
> *kobj,
>               desc.name, &desc.vid, &desc.pid, &desc.intf_id,
>               &desc.ip_devices, &desc.op_devices);
>
> -    if (num != 7)
> +    if (num != 6)
>           return -EINVAL;
>
>       num = gb_audio_manager_add(&desc);