Re: [PATCH net-next v3] net: stmmac: Use interrupt mode INTM=1 for per channel irq

[Nazle Asmade, Muhammad Nazim Amirul]

On 12/5/2026 11:56 pm, Jakub Raczynski wrote:
> [You don't often get email from j.raczynski@xxxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> On Mon, May 11, 2026 at 06:08:42PM -0700, Jakub Kicinski wrote:
>> On Thu,  7 May 2026 00:01:25 -0700
>> muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx wrote:
>>> - Wire up multi_irq_en via STMMAC_FLAG_MULTI_IRQ_EN in stmmac_main.c
>>>    so the feature is reachable by platform drivers.
>>
>> Okay, but where is a platform driver which uses it _today_ ?
>> We need an upstream platform that uses this new bit submitted
>> as part of the same series.
>>
>> If I'm completely off, and this new code somehow gets triggered
>> with upstream platforms - please improve the commit message.
>> --
>> pw-bot: cr
>>
> Please allow me to attach question to this response, but is this patch enough?
> 
> In stmmac code there is handler stmmac_request_irq() which deals with
> stmmac_request_irq_multi_msi() and single() aka shared IRQ.
> If INTM is enabled, does it really do anything if there is no handler within
> stmmac_request_irq() that would process all different IRQs, depending how
> is it wired on specific hardware? Or rather, shouldn't there be new function
> to call request_irq() per DMA channel for that?
> 
> There is e9ee910218ffd that reverted basically whole support for above,
> so I think this change is not sufficient.
> 
> Please correct me if I am wrong. Thank you.
> 
> BR
> Jakub Raczynski
> 
> 
Hi Jakub


After looking back your commit message above, it seems like this patch 
had been upstreamed before and was reverted together with another 3 due 
to one issue on DT side. I will re-send the new one with complete 
version in series. Thanks Jakub!