Re: [PATCH v6 1/3] mm/swap: rename mm/page_io.c to mm/swap_io.c

[Baoquan He]

On 05/12/26 at 10:21pm, Christoph Hellwig wrote:
> On Tue, May 12, 2026 at 06:41:59PM +0800, Baoquan He wrote:
> > Codes in mm/page_io.c are only related to swap io, it has
> > nothing to do with other page io.
> 
> That is true.  At the same time it also (mostly) isn't about all swap
> I/O, but specifically about the block based I/O backend for swap, and
> secondarily a little bit about helpers for the swsusp I/O to the swap
> file, with a little bit generic swap I/O wrappers thrown in.
> 
> So the new new isn't grest either.  And I'd rather wait with this until
"So the new isn't great either." ?

Take it easy, I can feel this abstraction falls into your area?

> we can nicely split stuff out - the rest of this series is a good step
> toward that, and my swap_activate series is another.  After that we
> should be able to stop creating swap_extent structures for
> SWP_FS_OPS-based I/O, and contain struct swap_extent with the bio code
> and actually create a coherent abstraction.  This will require moving
> a bit more code around, though.  My preference for the resulting name
> would be swap-block.c or swap-bio.c, but that's up for future
> discussion.
> 
> Can we just skip this for now?

Yes, I agree with you, and the swap_extent creating thing sounds great,
look forward to seeing it. I will drop this patch 1/3 in v7.