Re: [PATCH v3 01/10] file: add callback for creating long-term dmabuf maps
From: Christoph Hellwig
Date: Wed May 13 2026 - 04:14:23 EST
On Thu, Apr 30, 2026 at 07:33:39PM +0100, Pavel Begunkov wrote:
>> Then the patch should probably define the full interface and not just add the callback here and then the structure in a follow up patch.
>
> I strongly prefer splitting patches so that they touch one tree at
> a time whenever possible. tbh, I don't see much of a problem it being
> not defined as it's just forwarded in first patches, but I can shuffle
> it around in the series so that definitions come first.
file operations without users are pointless. This really should go
with "lib: add dmabuf token infrastructure" as it is the only way for
the reviewer to make any sense of it. I'll move my discussion of the
interface there for that reason.