Re: [PATCH] docs: reporting-issues: clarify advice wording
From: Thorsten Leemhuis
Date: Wed May 13 2026 - 04:16:26 EST
On 5/12/26 17:04, Chen-Shi-Hong wrote:
> A previous change
You mean the one you sent earlier we discussed? But that was not
applied, unless I'm missing something. So this should have been a v2 of
your patch (which a changelog) and against the same base (the one that
"these advices"). You want to send that as v3 now.
> replaced "these advices" with "this advice", but that
> wording can be read too narrowly and may seem to refer only to a single
> recommendation.
>
> Use "all of this advice" instead
That's great, thx. And thx to Jonathan for the suggestion!
Ciao, Thorsten
> to make it clearer that the sentence
> refers to the broader set of recommendations in the paragraph.
>
> Signed-off-by: Chen-Shi-Hong <eric039eric@xxxxxxxxx>
> ---
> Documentation/admin-guide/reporting-issues.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/reporting-issues.rst b/Documentation/admin-guide/reporting-issues.rst
> index 731865b5e8ff..87dd874fffcf 100644
> --- a/Documentation/admin-guide/reporting-issues.rst
> +++ b/Documentation/admin-guide/reporting-issues.rst
> @@ -129,7 +129,7 @@ After these preparations you'll now enter the main part:
> situations; during the merge window that actually might be even the best
> approach, but in that development phase it can be an even better idea to
> suspend your efforts for a few days anyway. Whatever version you choose,
> - ideally use a 'vanilla' build. Ignoring this advice will dramatically
> + ideally use a 'vanilla' build. Ignoring all of this advice will dramatically
> increase the risk your report will be rejected or ignored.
>
> * Ensure the kernel you just installed does not 'taint' itself when
> @@ -795,7 +795,7 @@ Install a fresh kernel for testing
> situations; during the merge window that actually might be even the best
> approach, but in that development phase it can be an even better idea to
> suspend your efforts for a few days anyway. Whatever version you choose,
> - ideally use a 'vanilla' built. Ignoring this advice will dramatically
> + ideally use a 'vanilla' built. Ignoring all of this advice will dramatically
> increase the risk your report will be rejected or ignored.*
>
> As mentioned in the detailed explanation for the first step already: Like most