Re: [PATCH v3 3/3] arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support

[Dmitry Baryshkov]

On Wed, May 13, 2026 at 12:58:05PM +0300, Abel Vesa wrote:
> On 26-05-13 12:44:00, Dmitry Baryshkov wrote:
> > On Wed, May 13, 2026 at 09:10:13AM +0300, Abel Vesa wrote:
> > > On 26-05-13 01:04:12, Dmitry Baryshkov wrote:
> > > > On Tue, May 12, 2026 at 03:26:49PM +0300, Abel Vesa wrote:
> > > > > The Eliza MTP features a single USB Type-C port. Its USB 2.0 lines are
> > > > > routed through an eUSB2 repeater provided by the PM7750BA PMIC.
> > > > > 
> > > > > Describe the port and repeater, and enable the USB controller and PHYs.
> > > > > 
> > > > > Also specify the ADSP firmware and enable the remoteproc.
> > > > > 
> > > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > > > > Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > > > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> > > > > ---
> > > > >  arch/arm64/boot/dts/qcom/eliza-mtp.dts | 81 ++++++++++++++++++++++++++++++++++
> > > > >  1 file changed, 81 insertions(+)
> > > > > 
> > > > > +
> > > > > +		connector@0 {
> > > > > +			compatible = "usb-c-connector";
> > > > > +			reg = <0>;
> > > > > +
> > > > > +			power-role = "dual";
> > > > > +			data-role = "dual";
> > > > > +
> > > > > +			ports {
> > > > > +				#address-cells = <1>;
> > > > > +				#size-cells = <0>;
> > > > > +
> > > > > +				port@0 {
> > > > > +					reg = <0>;
> > > > > +
> > > > > +					pmic_glink_hs_in: endpoint {
> > > > > +						remote-endpoint = <&usb_dwc3_hs>;
> > > > > +					};
> > > > > +				};
> > > > > +
> > > > > +				port@1 {
> > > > > +					reg = <1>;
> > > > > +
> > > > > +					pmic_glink_ss_in: endpoint {
> > > > > +						remote-endpoint = <&usb_dp_qmpphy_out>;
> > > > 
> > > > No redrivers?
> > > 
> > > It will come with the DP support.
> > 
> > Ideally this should have been a part of the commit message.
> 
> Why mention something that is part of a different support ?

Repeaters are a part of the USB chain as they also affect USB signals.

> In fact, there is no repeater, there is only an SBU MUX.
> 
> Which will only be brought in along with DP audio, IIUC.

Great, then there is no need to mention anything.


-- 
With best wishes
Dmitry