RE: [PATCH] IB/mlx4: delete allocated id_map_entry while sending REJ

[Praveen Kannoju]

Confidential - Oracle Restricted \Including External Recipients

HI Leon.
Thank you for the review.
Will reproduce the issue to collect kmemleak and reply you back with its output.

-
Praveen.


Confidential - Oracle Restricted \Including External Recipients
> -----Original Message-----
> From: Leon Romanovsky <leon@xxxxxxxxxx>
> Sent: Tuesday, May 12, 2026 6:28 PM
> To: Praveen Kannoju <praveen.kannoju@xxxxxxxxxx>
> Cc: yishaih@xxxxxxxxxx; jgg@xxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Anand Khoje <anand.a.khoje@xxxxxxxxxx>; Manjunath
> Patil <manjunath.b.patil@xxxxxxxxxx>
> Subject: Re: [PATCH] IB/mlx4: delete allocated id_map_entry while sending REJ
>
> On Wed, May 06, 2026 at 09:08:24AM +0000, Praveen Kumar Kannoju wrote:
> > During scenarios where a REJ is sent after a REQ or REP, the allocated
> > is_map_entry remains in memory, resulting in a memory leak. Scheduling
> > the entry for deletion during REJ handling, if it is not NULL,
> > resolves the issue.
>
> Do you have kmemleak output to prove the leak?
>
> >
> > Signed-off-by: Praveen Kumar Kannoju <praveen.kannoju@xxxxxxxxxx>
> > ---
> >  drivers/infiniband/hw/mlx4/cm.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/mlx4/cm.c
> > b/drivers/infiniband/hw/mlx4/cm.c index 63a868a3822f..21f2f401ed61
> > 100644
> > --- a/drivers/infiniband/hw/mlx4/cm.c
> > +++ b/drivers/infiniband/hw/mlx4/cm.c
> > @@ -321,10 +321,9 @@ int mlx4_ib_multiplex_cm_handler(struct ib_device
> *ibdev, int port, int slave_id
> >                             __func__, slave_id, sl_cm_id);
> >                     return PTR_ERR(id);
> >             }
> > -   } else if (mad->mad_hdr.attr_id == CM_REJ_ATTR_ID ||
> > -              mad->mad_hdr.attr_id == CM_SIDR_REP_ATTR_ID) {
> > +   } else if (mad->mad_hdr.attr_id == CM_SIDR_REP_ATTR_ID)
> >             return 0;
> > -   } else {
> > +   else {
>
> It is now similar to the "if (...  && REJ_REASON(mad) == IB_CM_REJ_TIMEOUT)"
> for active-side timeout above.
>
> Thanks
>
> >             sl_cm_id = get_local_comm_id(mad);
> >             id = id_map_get(ibdev, &pv_cm_id, slave_id, sl_cm_id);
> >     }
> > @@ -338,7 +337,8 @@ int mlx4_ib_multiplex_cm_handler(struct ib_device
> > *ibdev, int port, int slave_id
> >  cont:
> >     set_local_comm_id(mad, id->pv_cm_id);
> >
> > -   if (mad->mad_hdr.attr_id == CM_DREQ_ATTR_ID)
> > +   if (mad->mad_hdr.attr_id == CM_DREQ_ATTR_ID ||
> > +       mad->mad_hdr.attr_id == CM_REJ_ATTR_ID)
> >             schedule_delayed(ibdev, id);
> >     return 0;
> >  }
> > --
> > 2.43.7
> >