Re: [PATCH v4] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS

[Andy Shevchenko]

On Wed, May 13, 2026 at 06:42:57AM +0000, Harshit Shaw wrote:
> Replace direct device_create_file() calls with the correct
> ATTRIBUTE_GROUPS() macro. Add fbtft_groups as dev_groups in the
> driver structure so the driver core automatically adds and removes
> the sysfs attributes when a device is bound or unbound.

...

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

I need to withdraw this tag. Please, compile the code before sending.

You may not use ATTRIBUTE_GROUPS() in conjunction with extern.

-- 
With Best Regards,
Andy Shevchenko