Re: [PATCH v4 1/4] arm64: dts: qcom: monaco-evk: Extract common EVK hardware into shared dtsi

[Dmitry Baryshkov]

On Tue, May 05, 2026 at 07:17:17PM +0530, Umang Chheda wrote:
> Hi Dmitry,
> 
> On 5/5/2026 4:58 AM, Dmitry Baryshkov wrote:
> > On Tue, May 05, 2026 at 12:56:15AM +0530, Umang Chheda wrote:
> >> Hello Dmitry,
> >>
> >>
> >> On 5/5/2026 12:14 AM, Dmitry Baryshkov wrote:
> >>> On Mon, Apr 27, 2026 at 10:35:02PM +0530, Umang Chheda wrote:
> >>>> The monaco-ac EVK is a new board variant which shares the majority of
> >>>> its hardware description with the existing monaco-evk board.
> >>>
> >>> No, this is not a good reason. Is there a common PCB? There was a long
> >>> discussion for it for the Hamoa / Purwa EVK.
> >>
> >> PCB is not common for these 2 boards.
> >>
> >> Also, not sure if I mis-understood you - You had mentioned to have a
> >> common file for both the variants [1] in the earlier version of patch
> >> hence refactored it this way.
> > 
> > There was an explicit question if PCB is the same as a prerequisite for
> > the unification of DTS
> 
> 
> Thanks for the clarification.
> 
> This was discussed in the earlier v2 [1] — even though the PCB is not
> common, the majority of the hardware blocks and their wiring are
> functionally identical between monaco-evk and monaco-ac-evk, with only
> difference in H/W being 4 PMIC in monaco-evk v/s 2 PMIC on monaco-ac-evk
> and the rail which is supplied to the SDHC controller.
> 
> The intent here is to avoid duplication across the two boards rather
> than imply a shared PCB, similar to what was discussed earlier.
> 
> If this approach is still not acceptable without a common PCB, can I
> drop the refactoring and keep the DTS files fully separate ?

Judged on the previous suggestions by DT maintainers, there should be
separate DTS files.

> 
> [1]
> https://lore.kernel.org/all/8f79000d-ccbb-403c-871c-7a36423c9eee@xxxxxxxxxxxxxxxx/
> 
> > 
> >>
> >> [1]
> >> https://lore.kernel.org/lkml/7r6373fo56alzqa4e2zzdnsgwfhgdkmbhxe4cvdo4p7fg3zren@eyiml4uedfbn/
> >>
> >>>
> >>>>
> >>>> In preparation for adding this variant, extract the common hardware
> >>>> nodes from monaco-evk.dts into a new shared monaco-evk-common.dtsi
> >>>> include file, and update monaco-evk.dts to include it and keep only
> >>>> board-specific overrides.
> >>>>
> >>>> No functional change intended.
> >>>>
> >>>> Signed-off-by: Umang Chheda <umang.chheda@xxxxxxxxxxxxxxxx>
> >>>> ---
> >>>
> >>
> >> Thanks,
> >> Umang
> >>
> > 
> 
> Thanks,
> Umang
> 
> 

-- 
With best wishes
Dmitry