Re: [PATCH 4/4] thermal/core: Use the thermal class pointer as init guard

[Lukasz Luba]

On 5/8/26 19:05, Daniel Lezcano wrote:
> The thermal class is now dynamically allocated and stored as a
> pointer.
>
> Use the thermal_class pointer itself to check whether the thermal
> class has been created instead of keeping a separate
> thermal_class_unavailable flag.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxxxxxxxx>
> ---
>   drivers/thermal/thermal_core.c | 11 ++++-------
>   1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 748ab76823a3..81f6bbaded65 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -950,7 +950,6 @@ static void thermal_unbind_cdev_from_trip(struct thermal_zone_device *tz,
>   }
>   
>   static struct class *thermal_class;
> -static bool thermal_class_unavailable __ro_after_init = true;
>   
>   static inline
>   void print_bind_err_msg(struct thermal_zone_device *tz,
> @@ -1053,7 +1052,7 @@ __thermal_cooling_device_register(struct device_node *np,
>   	    !ops->set_cur_state)
>   		return ERR_PTR(-EINVAL);
>   
> -	if (thermal_class_unavailable)
> +	if (!thermal_class)
>   		return ERR_PTR(-ENODEV);
>   
>   	cdev = kzalloc_obj(*cdev);
> @@ -1536,7 +1535,7 @@ thermal_zone_device_register_with_trips(const char *type,
>   	if (polling_delay && passive_delay > polling_delay)
>   		return ERR_PTR(-EINVAL);
>   
> -	if (thermal_class_unavailable)
> +	if (!thermal_class)
>   		return ERR_PTR(-ENODEV);
>   
>   	tz = kzalloc_flex(*tz, trips, num_trips);
> @@ -1834,7 +1833,7 @@ static void __thermal_pm_prepare(void)
>   
>   void thermal_pm_prepare(void)
>   {
> -	if (thermal_class_unavailable)
> +	if (!thermal_class)
>   		return;
>   
>   	__thermal_pm_prepare();
> @@ -1865,7 +1864,7 @@ void thermal_pm_complete(void)
>   {
>   	struct thermal_zone_device *tz;
>   
> -	if (thermal_class_unavailable)
> +	if (!thermal_class)
>   		return;
>   
>   	guard(mutex)(&thermal_list_lock);
> @@ -1902,8 +1901,6 @@ static int __init thermal_init(void)
>   		goto unregister_governors;
>   	}
>   
> -	thermal_class_unavailable = false;
> -
>   	return 0;
>   
>   unregister_governors:


Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>