Re: [PATCH v6 3/3] mm/swap_io.c: rename swap_writepage_* to swap_write_folio_*
From: Baoquan He
Date: Wed May 13 2026 - 12:04:21 EST
On 05/12/26 at 10:36pm, Christoph Hellwig wrote:
> >
> > static const struct swap_ops bdev_fs_swap_ops = {
> > .read_folio = swap_read_folio_fs,
> > - .write_folio = swap_writepage_fs,
> > + .write_folio = swap_write_folio_fs,
> > };
>
> The convention for method naming is prefix##method_name, i.e.
> swap_fs_read_folio, swap_fs_write_folio, swap_bdev_sync_read_folios,
> etc.
To me _fs is a modifier to qualify the method type. If need change, we
may need change all swap_readxxx_fs/bdev_sync/bdev_async and swap_writexxx
likewise.