Re: [PATCH 2/2] clk: qcom: nord: negcc: add missing definition for the USB2 PHY reset
From: Bartosz Golaszewski
Date: Wed May 13 2026 - 12:51:41 EST
On Wed, May 13, 2026 at 5:35 PM Bartosz Golaszewski
<bartosz.golaszewski@xxxxxxxxxxxxxxxx> wrote:
>
> The USB2 PHY reset definition is missing from the negcc clock driver and
> its bindings. Provide it in order to enable adding the USB nodes in DTS.
>
> Fixes: a4f780cd5c7a ("clk: qcom: gcc: Add multiple global clock controller driver for Nord SoC")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> ---
> drivers/clk/qcom/negcc-nord.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/negcc-nord.c b/drivers/clk/qcom/negcc-nord.c
> index 1aa24e2784e536e6b6e76f488abd0e2fcc435380..31442d39924a6f79bf39962ebb0de8d5c65fa0b0 100644
> --- a/drivers/clk/qcom/negcc-nord.c
> +++ b/drivers/clk/qcom/negcc-nord.c
> @@ -1918,6 +1918,7 @@ static const struct qcom_reset_map ne_gcc_nord_resets[] = {
> [NE_GCC_USB3_PHY_SEC_BCR] = { 0x2d000 },
> [NE_GCC_USB3PHY_PHY_PRIM_BCR] = { 0x2b004 },
> [NE_GCC_USB3PHY_PHY_SEC_BCR] = { 0x2d004 },
> + [NE_GCC_QUSB3PHY_PRIM_BCR] = { 0x2e000 },
> };
>
> static const struct clk_rcg_dfs_data ne_gcc_nord_dfs_clocks[] = {
>
> --
> 2.47.3
>
Please disregard this, the address is correct but it was supposed to
be called NE_GCC_QUSB2PHY_PRIM_BCR instead. I'll send a v2 on Monday.
Bart