Re: [PATCH v2 1/4] iio: light: veml6030: remove unnecessary read of IT index
From: Andy Shevchenko
Date: Wed May 13 2026 - 13:12:40 EST
On Wed, May 13, 2026 at 05:49:41PM +1300, Javier Carrasco wrote:
> This is dead code as the IT index is not used by gts to set the new scale.
> In its current form, the value is read but not used afterward. Remove
> the dead code.
Does it have any side-effects on the HW side? Exempli gratia, flushing FIFO,
R1C (read to clear 1) bits?
> Fixes: 22eaca4283b2 ("iio: light: veml6030: fix scale to conform to ABI")
Not sure it fixes anything. But it might regress, see above why.
...
If no side-effects, the code wise looks good.
--
With Best Regards,
Andy Shevchenko