Re: [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig

[Andy Shevchenko]

On Wed, May 13, 2026 at 05:46:03PM +0100, Richard Fitzgerald wrote:
> On 13/05/2026 5:27 pm, Andy Shevchenko wrote:
> > First of all, it has to be 'default n' (small letter n), otherwise
> > it looks for CONFIG_N which is absent and in case of appearance
> > will enable something unrelated. Second and most important is that
> > 'n' *is* the default 'default' already. Hence just drop malformed
> > line.
> 
> The redundant default was added intentionally to be explicit that the
> default really must be "no". But if that sort of thing is forbidden you
> can drop the line.

Torvalds gave his opinion on the Subject a few years ago, here is what he would
do.

0192f17529fa ("clean up x86 platform driver default values")

> I apologize for the typo, but that is why you shouldn't use case
> difference as language syntax.

It's not me whom you should ask for that :-)

-- 
With Best Regards,
Andy Shevchenko