Re: [PATCH] sched_ext: Fix spurious WARN on stale ops_state in ops_dequeue()
From: Tejun Heo
Date: Wed May 13 2026 - 16:02:45 EST
Hello,
On Wed, May 13, 2026 at 06:41:26PM +0200, Samuele Mariotti wrote:
> if (!(READ_ONCE(p->scx.flags) & SCX_TASK_IN_CUSTODY) &&
> !WARN_ON_ONCE(retries++ >= 4)) {
> cpu_relax();
> goto retry;
> }
Let's not do the WARN and exit. We shouldn't get this wrong and if we get
this wrong, it's going to be obvious from lockup detectors. Can you please
add a comment explaining the retry condition tho?
Thanks.
--
tejun