[PATCH 4/4] staging: rtl8723bs: make _rtw_enqueue_cmd return 0 on success
From: Hungyu Lin
Date: Wed May 13 2026 - 17:37:56 EST
Convert the private helper _rtw_enqueue_cmd() to return 0 on
success instead of the legacy _SUCCESS value.
Keep rtw_enqueue_cmd() translating the result back to the
existing return convention for now.
No functional change intended.
Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index b0596b52a9fd..4205f24a5a06 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -252,7 +252,7 @@ static int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj)
unsigned long irqL;
if (!obj)
- return _SUCCESS;
+ return 0;
/* spin_lock_bh(&queue->lock); */
spin_lock_irqsave(&queue->lock, irqL);
@@ -262,7 +262,7 @@ static int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj)
/* spin_unlock_bh(&queue->lock); */
spin_unlock_irqrestore(&queue->lock, irqL);
- return _SUCCESS;
+ return 0;
}
struct cmd_obj *_rtw_dequeue_cmd(struct __queue *queue)
@@ -328,10 +328,12 @@ int rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
res = _rtw_enqueue_cmd(&pcmdpriv->cmd_queue, cmd_obj);
- if (res == _SUCCESS)
+ if (res == 0) {
complete(&pcmdpriv->cmd_queue_comp);
+ return _SUCCESS;
+ }
- return res;
+ return _FAIL;
}
struct cmd_obj *rtw_dequeue_cmd(struct cmd_priv *pcmdpriv)
--
2.34.1