Re: [PATCH] perf trace beauty fcntl: Fix build with older kernel headers

[Ian Rogers]

On Wed, May 13, 2026 at 2:56 PM Florian Fainelli
<florian.fainelli@xxxxxxxxxxxx> wrote:
>
> On 5/13/26 13:58, Ian Rogers wrote:
> > On Wed, May 13, 2026 at 12:23 PM Florian Fainelli
> > <florian.fainelli@xxxxxxxxxxxx> wrote:
> >>
> >> Toolchains with older kernel headers that do not include upstream commit
> >> c75b1d9421f80f4143e389d2d50ddfc8a28c8c35 ("fs: add fcntl() interface for
> >> setting/getting write life time hints") will now fail to build perf due
> >> to missing definitions for
> >> F_GET_RW_HINT/F_SET_RW_HINT/F_GET_FILE_RW_HINT/F_SET_FILE_RW_HINT.
> >>
> >> Provide a fallback definition for these when they are not already
> >> defined.
> >
> > This seems fine but the commit you mention was added to Linux 4.13. Is
> > there a reason you've run into this problem? The oldest active LTS
> > kernel is 4.19.
>
> The toolchain I am using is still on kernel headers 4.9.x, I am
> cognizant this is a very old set of kernel headers, this is specific and
> unique to building for MIPS, our ARM/ARM64 targets are using more modern
> components.

Sgtm. I have some libunwind clean up for MIPS that I'll add you to, in
case it is of interest since I can't test it myself :-)

For this patch:
Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> --
> Florian