Re: [net-next v8 3/3] net: ethernet: mtk_eth_soc: Add LRO support

From: Jakub Kicinski

Date: Wed May 13 2026 - 21:54:20 EST


On Sat, 9 May 2026 21:09:32 +0200 Frank Wunderlich wrote:
> + mtk_rx_irq_disable(eth, MTK_RX_DONE_INT(eth, MTK_HW_LRO_RING(eth, i)));
> + napi_synchronize(&eth->rx_napi[MTK_HW_LRO_RING(eth, i)].napi);
> + napi_disable(&eth->rx_napi[MTK_HW_LRO_RING(eth, i)].napi);

What purpose that napi_synchronize() serve?
Also we don't charge for temporary variables, maybe save that
MTK_HW_LRO_RING(eth, i) to make this slightly more readable.