RE: [PATCH v3 0/9] iio: introduce devm_ API for hid sensro setup and cleanup
From: Zhang, Lixu
Date: Wed May 13 2026 - 22:48:11 EST
Tested-by: Zhang Lixu <lixu.zhang@xxxxxxxxx>
>-----Original Message-----
>From: Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>
>Sent: Saturday, May 9, 2026 6:11 PM
>To: jikos@xxxxxxxxxx; jic23@xxxxxxxxxx; srinivas.pandruvada@xxxxxxxxxxxxxxx
>Cc: Lechner, David <dlechner@xxxxxxxxxxxx>; nuno.sa@xxxxxxxxxx;
>andy@xxxxxxxxxx; sanjayembeddedse@xxxxxxxxx;
>sakari.ailus@xxxxxxxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx; linux-
>iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Subject: [PATCH v3 0/9] iio: introduce devm_ API for hid sensro setup and
>cleanup
>
>From: Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>
>
>Key highlights:
>- Prepare change as pre-requisite for devm conversion for HID IIO
> drivers by removing redundant argument
>- Add devm API to setup trigger and clenaup resource using
> devm_add_action_or_reset()
>- few cleanup and prepratory changes before updating driver for devm_
>- few sample driver update using devm conversion to auto release resource
>
>changes in v3:
>- Added cleanup and prepratory changes before adding devm_ API
> conversion based on self review: 0002, 0004, 0006, 0007 and 0008
>- Address andy's review comment on commit message and coding style
>- v2 series -> https://lore.kernel.org/all/20260429175918.2541914-1-
>sanjayembedded@xxxxxxxxx/
>changes in v2:
>- Following input from Jonathan and Andy, squash initial patch v1
> series in single change as individual change should not break anything
>- Add devm API support and two driver using the same
>- v1 series -> https://lore.kernel.org/all/20260428071613.1134053-1-
>sanjayembedded@xxxxxxxxx/
>
>Testing:
> - Compiled with W=1
> - Build-tested on QEMU x86_64
>
>Based on further feedback and reviews, I would extend this series to convert all
>HID IIO driver to use devm_* API.
>
>Thanks,
>Sanjay Chitroda
>
>
>Sanjay Chitroda (9):
> iio: hid-sensors: drop redundant iio_dev argument
> iio: hid-sensors: cleanup codestyle warning
> iio: hid-sensors: introduce device managed API
> iio: gyro: hid-sensor-gyro-3d: cleanup codestyle warning
> iio: gyro: hid-sensor-gyro-3d: drop hid_sensor_remove_trigger() using
> devm API
> iio: humidity: hid-sensor-humidity: cleanup codestyle check
> iio: humidity: hid-sensor-humidity: use common device for devres
> iio: humidity: hid-sensor-humidity: use local struct device
> iio: humidity: hid-sensor-humidity: drop hid_sensor_remove_trigger()
> using devm API
>
> drivers/iio/accel/hid-sensor-accel-3d.c | 4 +-
> .../common/hid-sensors/hid-sensor-trigger.c | 24 +++++++-
> .../common/hid-sensors/hid-sensor-trigger.h | 5 +-
> drivers/iio/gyro/hid-sensor-gyro-3d.c | 16 ++---
> drivers/iio/humidity/hid-sensor-humidity.c | 61 +++++++++----------
> drivers/iio/light/hid-sensor-als.c | 4 +-
> drivers/iio/light/hid-sensor-prox.c | 4 +-
> drivers/iio/magnetometer/hid-sensor-magn-3d.c | 4 +-
>drivers/iio/orientation/hid-sensor-incl-3d.c | 4 +- drivers/iio/orientation/hid-
>sensor-rotation.c | 4 +- .../position/hid-sensor-custom-intel-hinge.c | 4 +-
> drivers/iio/pressure/hid-sensor-press.c | 4 +-
> .../iio/temperature/hid-sensor-temperature.c | 4 +-
> 13 files changed, 78 insertions(+), 64 deletions(-)
>
>
>base-commit: 39b80c5c9830d12d2d6531059001301c4265322a
>--
>2.34.1
>