回复: [PATCH v1 1/2] dt-bindings: Add bindings for StarFive JHB100 SoC trng controller.

[Lianfeng Ouyang]

> -----邮件原件-----
> 发件人: Conor Dooley <conor@xxxxxxxxxx>
> 发送时间: 2026年5月13日 3:36
> 收件人: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>
> 抄送: Olivia Mackall <olivia@xxxxxxxxxxx>; Herbert Xu
> <herbert@xxxxxxxxxxxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Philipp
> Zabel <p.zabel@xxxxxxxxxxxxxx>; linux-crypto@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> 主题: Re: [PATCH v1 1/2] dt-bindings: Add bindings for StarFive JHB100 SoC trng
> controller.
> 
> On Tue, May 12, 2026 at 06:15:07PM +0100, Conor Dooley wrote:
> > On Tue, May 12, 2026 at 02:24:03PM +0800, lianfeng.ouyang wrote:
> > > From: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>
> > >
> > > Signed-off-by: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>
> > > ---
> > >  Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml | 2
> > > +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> > > b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> > > index 4639247e9e51..11346d77b2f6 100644
> > > ---
> > > a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> > > +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yam
> > > +++ l
> > > @@ -13,8 +13,8 @@ properties:
> > >    compatible:
> > >      oneOf:
> > >        - items:
> > > -          - const: starfive,jh8100-trng
> > >            - const: starfive,jh7110-trng
> > > +          - const: starfive,jhb100-trng
> >
> > You need to add a commit message here explaining why removing the
> > jh8100 is okay.
> > pw-bot: changes-requested

Okay, Jh8100 will no longer be supported, so it will be removed from the driver. In the next version, I will add these descriptions to the commit message

> 
> Additionally, given the driver changes, it looks like using a jh7110 fallback is
> invalid anyway.

Thank you for your correction. The next version will be revised as follows
  compatible:
    enum:
      - starfive,jh7110-trng
      - starfive,jhb100-trng

> 
> >
> > >        - const: starfive,jh7110-trng
> > >
> > >    reg:
> > > --
> > > 2.43.0
> > >
> > >
>