Re: [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked()
From: Oleg Nesterov
Date: Thu May 14 2026 - 04:19:16 EST
On 05/13, Andrew Morton wrote:
>
> On Sat, 2 May 2026 16:13:12 +0200 Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> > force_sig_info_to_task() calls send_signal_locked() but this is pointless;
> > info is always valid and has_si_pid_and_uid(info) should never be true.
> > Forced signals do not carry si_pid/si_uid, not to mention that info.si_pid
> > overlaps with .si_addr/si_call_addr/etc.
>
> Thanks. AI review said things:
> https://sashiko.dev/#/patchset/afYGeHSWkLzXDlvC@xxxxxxxxxx
Yes, yes, thanks.
I have already replied,
https://lore.kernel.org/all/afhmbCryeyIz0E3V@xxxxxxxxxx/
Sashiko is right. Again!!!
This needs another version.
Oleg.