Re: [PATCH 2/2] soc: qcom: rpmpd: Add Shikra RPM Power Domains

[Konrad Dybcio]

On 5/14/26 11:16 AM, Dmitry Baryshkov wrote:
> On Thu, May 14, 2026 at 02:15:12PM +0530, Rakesh Kota wrote:
>> On Tue, May 12, 2026 at 02:16:07PM +0200, Konrad Dybcio wrote:
>>> On 4/29/26 4:09 PM, Rakesh Kota wrote:
>>>> Add RPM Power Domains support for the Shikra platform.
>>>>
>>>> Signed-off-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
>>>> ---
>>>>  drivers/pmdomain/qcom/rpmpd.c | 16 ++++++++++++++++
>>>>  1 file changed, 16 insertions(+)
>>>>
>>>> diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c
>>>> index 15a11ff282c3f86b1e86c6604d165e297620f6cf..6f751ee5a7833912d54d2bcfd5d85837ab7a97d3 100644
>>>> --- a/drivers/pmdomain/qcom/rpmpd.c
>>>> +++ b/drivers/pmdomain/qcom/rpmpd.c
>>>> @@ -863,6 +863,21 @@ static const struct rpmpd_desc sdm660_desc = {
>>>>  	.max_state = RPM_SMD_LEVEL_TURBO,
>>>>  };
>>>>  
>>>> +static struct rpmpd *shikra_rpmpds[] = {
>>>> +	[RPMPD_VDDCX] =		&cx_rwcx0_lvl,
>>>> +	[RPMPD_VDDCX_AO] =	&cx_rwcx0_lvl_ao,
>>>> +	[RPMPD_VDDCX_VFL] =	&cx_rwcx0_vfl,
>>>> +	[RPMPD_VDDMX] =		&mx_rwmx0_lvl,
>>>> +	[RPMPD_VDDMX_AO] =	&mx_rwmx0_lvl_ao,
>>>> +	[RPMPD_VDDMX_VFL] =	&mx_rwmx0_vfl,
>>>> +};
>>>
>>> This is identical to sm6125_rpmpds. If you're sure the list is correct
>>> and complete (no LPI domains etc.), you can drop this patch, and proceed
>>> with just this change:
>>>
>> There is one difference — the max_state for Shikra is
>> RPM_SMD_LEVEL_TURBO_NO_CPR, whereas sm6125 uses RPM_SMD_LEVEL_BINNING. 
> 
> It's handled in the DT. As such, programming model and the domain list
> looks the same and compatible.

Yes/no, this is an upper bound

one improvement we could still make to this patch is not to define
shikra_rpmpds[], but refer to the existing sm6125 one

Konrad