[PATCH v2 3/4] tools/nolibc: always pass mode to open syscall

[Thomas Weißschuh]

When O_TMPFILE is set, the open mode needs to be passed to the kernel as
per the documentation. Currently this is not done.
Instead of checking for O_TMPFILE explicitly and making the conditionals
more complex, just always pass the mode to the kernel. If no value was
passed the mode will be garbage, but the kernel will ignore it anyways.

Fixes: a7604ba149e7 ("tools/nolibc/sys: make open() take a vararg on the 3rd argument")
Suggested-by: Willy Tarreau <w@xxxxxx>
Link: https://lore.kernel.org/lkml/afRfjdovT6pNtwtP@xxxxxx/
Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
---
 tools/include/nolibc/fcntl.h | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/tools/include/nolibc/fcntl.h b/tools/include/nolibc/fcntl.h
index d7ea02e1332d..d4b6af60d4cc 100644
--- a/tools/include/nolibc/fcntl.h
+++ b/tools/include/nolibc/fcntl.h
@@ -18,15 +18,12 @@
 
 #define __nolibc_open_mode(_flags)							\
 ({											\
-	mode_t _mode = 0;								\
+	mode_t _mode;									\
+	va_list args;									\
 											\
-	if ((_flags) & O_CREAT) {							\
-		va_list args;								\
-											\
-		va_start(args, (_flags));						\
-		_mode = va_arg(args, mode_t);						\
-		va_end(args);								\
-	}										\
+	va_start(args, (_flags));							\
+	_mode = va_arg(args, mode_t);							\
+	va_end(args);									\
 											\
 	_mode;										\
 })

-- 
2.54.0