Re: [PATCH v2 2/2] dt-bindings: Add GPIO locked fixed clock
From: Krzysztof Kozlowski
Date: Thu May 14 2026 - 08:11:16 EST
On Sun, May 10, 2026 at 06:06:23PM +0000, Vyacheslav Yurkov wrote:
> Describe device tree binding for a fixed clock, which state can only be
> determined by the external GPIO. It's similar to gated-fixed-clock, but
> the GPIO direction is inverted.
v1 comments - do not ask us to repeat them.
"Please explain how I would identify this h/w."
>
> Signed-off-by: Vyacheslav Yurkov <uvv.mail@xxxxxxxxx>
> Signed-off-by: Vyacheslav Yurkov <V.Yurkov.EXT@xxxxxxxxxx>
> ---
> .../bindings/clock/gpio-locked-fixed-clock.yaml | 77 ++++++++++++++++++++++
> 1 file changed, 77 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/gpio-locked-fixed-clock.yaml b/Documentation/devicetree/bindings/clock/gpio-locked-fixed-clock.yaml
> new file mode 100644
> index 000000000000..e0256bbd441d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/gpio-locked-fixed-clock.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/gpio-locked-fixed-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO Locked Fixed Clock
> +
> +maintainers:
> + - Vyacheslav Yurkov <V.Yurkov.EXT@xxxxxxxxxx>
> +
> +description: |
> + Clock controller that aggregates input clocks and/or GPIO
> + signals and exposes them as a single clock output.
So same comments as before. We gave you multiple comments, multiple
expectations.
I see here no real hardware explanation and I asked for it more than
ONCE.
Best regards,
Krzysztof