Re: [PATCH v3 1/2] PCI: Add D3cold as general reset method

[Jose Ignacio Tornos Martinez]

Hello Lukas,

> Why fall back to D3hot, even though the name of the reset method
> suggests it uses D3cold?  If D3cold isn't supported, I'd just not
> expose the new reset method.
Ok, the next version will include D3cold only if supported.

> I'd call it "powercycle" for clarity but that's just my preferred
> bikeshed color.
I don't have any preference, although we can understand clearer what
it is. If there are consensus, I am ok with powercycle.

> So I'd just return -ENOTTY here in the !pci_pr3_present() case
> and I'd do that for probe == 0 as well.
Ok, I am going to wait for Alex Williamson opinion for the other cases
but I will do this as you say in the next version.

Thanks

Best regards
José Ignacio