Re: [PATCH v4 1/5] net: lan743x: rename is_sgmii_en to is_pcs_en

[Andrew Lunn]

On Thu, May 14, 2026 at 04:20:24PM +0530, Thangaraj Samynathan wrote:
> The flag is_sgmii_en indicates whether the PCS interface is enabled.
> However, the name implies that the interface is strictly SGMII, which is
> misleading.
> 
> Rename the variable to is_pcs_en to better reflect that the flag
> represents the PCS enable state rather than a specific interface mode.
> Update all references and logs accordingly (but keep device registers
> unchanged to match its documentation).

So the documentation is also broken?

Can you get the documentation fixes, and then replace all references
of SGMII to PCS?

> -	if (adapter->is_pci11x1x && adapter->is_sgmii_en)
> +	if (adapter->is_pci11x1x && adapter->is_pcs_en)
>  		adapter->phy_interface = PHY_INTERFACE_MODE_SGMII;

Maybe this is in a later patch in this series, but i assume
PHY_INTERFACE_MODE_1000BASEX is also a potential mode?

	Andrew