Re: [PATCH v2 2/2] drm/bridge: lt9211: Add drive-strength-microamp DT property

[Marek Vasut]

On 5/14/26 1:20 PM, Börge Strümpfel wrote:
> On Wed, May 13, 2026 at 03:45:43PM +0200, Marek Vasut wrote:
> > On 5/13/26 3:31 PM, Boerge Struempfel wrote:
> >
> > [...]
> >
> > > @@ -666,6 +675,26 @@ static int lt9211_parse_dt(struct lt9211 *ctx)
> > >    
> > >    	ctx->panel_bridge = panel_bridge;
> > >    
> > > +	ctx->lvds_hsdrv_isel = 8; /* default: 25 uA */
> > > +	ret = of_property_read_u32(dev->of_node, "drive-strength-microamp",
> > > +				   &microamp);
> >
> > if (ret && ret != -EINVAL) {
> >     ... error handling ...
> >     return ret;
> > }
> >
> > Then you won't need the if (!ret) conditional and can reduce indent.
>
> Thank you for this suggestion. We will than need to do the lookup even
> in case of no value being supplied, but that would make the code
> cleaner. Therefore I am changing this in v3.
of_property_read_u32() returns -ENODATA if property does not have a 
value -> the error handling above would detect that.