Re: [PATCH v2 1/3] dt-bindings: crypto: qcom,ice: Add sa8255p support

[Krzysztof Kozlowski]

On Mon, May 11, 2026 at 08:37:48PM -0700, Linlin Zhang wrote:
> On sa8255p, resources such as PHY, clocks, regulators, and resets are
> managed by remote firmware via the SCMI power protocol. As a result, the
> ICE driver cannot directly access clocks and must instead use power-domains
> to request resource configuration.

Then how can it be compatible with qcom,inline-crypto-engine?

> 
> Add the qcom,sa8255p-inline-crypto-engine compatible string and make clocks
> optional for platforms that use power-domains instead.
> 
> Signed-off-by: Linlin Zhang <linlin.zhang@xxxxxxxxxxxxxxxx>
> ---
>  .../crypto/qcom,inline-crypto-engine.yaml     | 27 ++++++++++++++++++-
>  1 file changed, 26 insertions(+), 1 deletion(-)

So this is v2? But previous was v6? Look:

b4 diff '20260512033750.3393050-1-linlin.zhang@xxxxxxxxxxxxxxxx'
Looking up https://lore.kernel.org/all/20260512033750.3393050-1-linlin.zhang@xxxxxxxxxxxxxxxx/
Grabbing thread from lore.kernel.org/all/20260512033750.3393050-1-linlin.zhang@xxxxxxxxxxxxxxxx/t.mbox.gz
Checking for older revisions
Grabbing search results from lore.kernel.org
---
Analyzing 8 messages in the thread
Could not find lower series to compare against.


> 
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> index 876bf90ed96e..4e7d9111d0eb 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml

This should go to its own binding file just like in all other
SCMI-variant cases. And if you looked how these other files are done,
you would see my complains already that generic fallback is most likely
wrong.

Otherwise explain me what the generic fallback means here and how is it
supposed to work?

Best regards,
Krzysztof