Re: [PATCH 0/2] scsi: smartpqi: fix PCIe hot reset recovery
From: Don.Brace
Date: Thu May 14 2026 - 10:39:31 EST
________________________________________
From: Mateusz Nowicki <mateusz.nowicki@xxxxxxxxxx>
Sent: Wednesday, May 6, 2026 9:01 AM
To: Don Brace - C33706 <Don.Brace@xxxxxxxxxxxxx>
Cc: martin.petersen@xxxxxxxxxx <martin.petersen@xxxxxxxxxx>; James.Bottomley@xxxxxxxxxxxxxxxxxxxxx <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>; storagedev <storagedev@xxxxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx <linux-scsi@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>
Subject: [PATCH 0/2] scsi: smartpqi: fix PCIe hot reset recovery
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
A PCIe bus reset (e.g. "echo 1 > /sys/bus/pci/devices/<bdf>/reset") on a
controller without FLR support leaves the HPE SR932i-p Gen10+ unusable
until reboot: smartpqi registers no pci_error_handlers, so the driver
is not notified, firmware reverts to SIS mode, and all queue mappings
are dropped while the driver still drives PQI.
Patch 1 adds .reset_prepare / .reset_done reusing
pqi_ofa_ctrl_quiesce() / _unquiesce() / pqi_ctrl_init_resume().
Patch 2 raises SIS_CTRL_READY_RESUME_TIMEOUT_SECS from 90s to 180s,
matching the cold-boot path; without this patch 1 fails at the SIS
ready check because firmware boot after reset takes ~125s on the
SR932i-p Gen10+.
Tested on HPE SR932i-p Gen10+ against Linus' master at 74fe02ce122a.
Thanks for the patch.
NAK for now.
Before we ack, we want to run this through internal regression on the SR-series
— particularly the OFA + bus-reset interaction in patch 1 and whether the 180s timeout in patch 2 should apply universally or
be controller-gated. This may lead to changes in your patches.