Re: [PATCH net 5/5] mptcp: update window_clamp on subflows when SO_RCVBUF is set
From: Matthieu Baerts
Date: Thu May 14 2026 - 13:32:22 EST
Hi Jakub,
13 May 2026 04:29:26 Jakub Kicinski <kuba@xxxxxxxxxx>:
> On Tue, 12 May 2026 18:26:11 -0700 Jakub Kicinski wrote:
>> On Tue, 12 May 2026 15:02:20 +0200 Matthieu Baerts wrote:
>>> Arf, I missed that when reviewing this patch: the 'inline' keyword
>>> should be dropped here.
>>
>> I'll drop when applying
>
> Let me take that back, IDK why the Fixes tag points to the commit that
> fixes the issue for TCP. I don't think that commit broke MPTCP did it?
Indeed, it doesn't break MPTCP, but it fixes TCP without fixing MPTCP :-P
More seriously, this patch needs to be applied everywhere the TCP fix is.
In the v2, I can add the same Fixes tag as the fix for TCP.
> Also there's a review in netdev's patchwork for patch 2.
Thank you, I missed that one. Nothing to change there, but I can add a
note in the commit message in the v2.
Cheers,
Matt