[PATCH] RAS/CEC: Use IS_ERR() checks in create_debugfs_nodes()
From: Ingyu Jang
Date: Thu May 14 2026 - 15:33:24 EST
debugfs_create_dir() and debugfs_create_file() return an error pointer
on failure, never NULL, so the NULL checks in create_debugfs_nodes()
are unreachable and the dedicated error paths cannot run.
Replace each NULL check with an IS_ERR() check.
Signed-off-by: Ingyu Jang <ingyujang25@xxxxxxxxxxx>
---
drivers/ras/cec.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index 15f7f043c8efd..253aa734f05ff 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -489,21 +489,21 @@ static int __init create_debugfs_nodes(void)
}
d = debugfs_create_dir("cec", dfs);
- if (!d) {
+ if (IS_ERR(d)) {
pr_warn("Error creating cec debugfs node!\n");
return -1;
}
decay = debugfs_create_file("decay_interval", S_IRUSR | S_IWUSR, d,
&decay_interval, &decay_interval_ops);
- if (!decay) {
+ if (IS_ERR(decay)) {
pr_warn("Error creating decay_interval debugfs node!\n");
goto err;
}
count = debugfs_create_file("action_threshold", S_IRUSR | S_IWUSR, d,
&action_threshold, &action_threshold_ops);
- if (!count) {
+ if (IS_ERR(count)) {
pr_warn("Error creating action_threshold debugfs node!\n");
goto err;
}
@@ -512,13 +512,13 @@ static int __init create_debugfs_nodes(void)
return 0;
pfn = debugfs_create_file("pfn", S_IRUSR | S_IWUSR, d, &dfs_pfn, &pfn_ops);
- if (!pfn) {
+ if (IS_ERR(pfn)) {
pr_warn("Error creating pfn debugfs node!\n");
goto err;
}
array = debugfs_create_file("array", S_IRUSR, d, NULL, &array_fops);
- if (!array) {
+ if (IS_ERR(array)) {
pr_warn("Error creating array debugfs node!\n");
goto err;
}
--
2.34.1