Re: [PATCH v2] wifi: ath11k: Add two missing Lenovo IDs to the quirk table

From: Jeff Johnson

Date: Thu May 14 2026 - 18:55:09 EST


On 5/13/2026 10:01 PM, Kyle Farnung wrote:
> On Wed, May 13, 2026 at 10:57 AM Santiago Ruano Rincón
> <santiagorr@xxxxxxxxxx> wrote:
>>
>> El 12/05/26 a las 20:30, Kyle Farnung escribió:
>>> On Tue, May 12, 2026 at 5:03 PM Jeff Johnson
>>> <jeff.johnson@xxxxxxxxxxxxxxxx> wrote:
>>>>
>>>> On 5/6/2026 12:54 PM, Santiago Ruano Rincón wrote:
>>>>> Commit 0eb002c93c3b4 ("wifi: ath11k: Add missing platform IDs for quirk
>>>>> table") added some Lenovo platform IDs to the quirk table to address a
>>>>> wakeup from suspend issue [1]. However, at least P14s Gen 5 AMD, as
>>>>> reported by Kyle Farnung [2], and P14s Gen 3 AMD are missing in the
>>>>> table. This commit adds the two corresponding Lenovo version IDs for
>>>>> each.
>>>>>
>>>>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=219196
>>>>> [2] https://bugzilla.kernel.org/show_bug.cgi?id=219196#c23
>>>>>
>>>>> Tested-on: P14s G3 AMD running 7.0.3.
>>>>>
>>>>> Fixes: ce8669a27016 ("wifi: ath11k: determine PM policy based on machine model")
>>>>> Co-authored-by: Kyle Farnung <kfarnung@xxxxxxxxx>
>>>>
>>>> This is not a standard Linux kernel commit tag.
>>>> Co-developed-by: could be used, but I'd need a Signed-off-by: from Kyle
>>>>
>>>> Kyle, if you'd like these added please reply with both a Co-developed-by and
>>>> a Signed-off-by tag
>>>
>>> I re-tested the bug behavior on the v7.0.4 tag and found that I'm not able
>>> to reproduce it on my device. I put the device to sleep and then unplugged
>>> and replugged power; it never woke up until I intentionally woke it.
>>>
>>> Based on discussion in [3], I narrowed my issue with wi-fi disassociation
>>> on wake to a suspect commit [4]. I'm developing a patch that clears the rdp
>>> and wrp buffers during wake to clear out any stale state in the LMAC rings.
>>> I'll submit that once I'm done testing it.
>>>
>>> Santiago: Are you seeing the sleep/wake bug from [1] or something similar
>>> to what I was seeing around disconnections on wake?
>>
>> I was seeing wifi issues after wake-up, including disassociations, as
>> described at https://bugs.debian.org/1132343.
>
> Thanks for the confirmation. I went ahead and submitted a patch for the
> suspected SRNG restart issue in [5].
>
> For my P14s Gen 5 AMD, I don't think the PM quirk is the right fix at
> this point, so please don't include the 21ME/21MF IDs on my account for
> now. This new patch seems like a better match for the disassociation
> issue I was seeing after resume.

Based upon this I'm dropping this patch.

Santiago, if Kyle's patch doesn't fix your problem feel free to resubmit
adding just the quirks needed by your machine.

/jeff