Re: [PATCH net-next] net: neigh: Rename NEIGH_VAR_INTERVAL_PROBE_TIME_MS to NEIGH_VAR_INTERVAL_PROBE_TIME

[qiu.yutan]

On 5/15/26 10:55 AM, Jiayuan Chen <jiayuan.chen@xxxxxxxxx> wrote:
>> From: Qiu Yutan <qiu.yutan@xxxxxxxxxx>
>>
>> During the initialization of arp_tbl, the enumeration constant name
>> NEIGH_VAR_INTERVAL_PROBE_TIME_MS in the statement
>> arp_tbl.parms.data[NEIGH_VAR_INTERVAL_PROBE_TIME_MS] = 5*HZ does not
>> align with its actual meaning (jiffies).
>I think the macro name NEIGH_VAR_INTERVAL_PROBE_TIME is just meant to 
>correspond
>
>to the configuration item neigh/default/interval_probe_time_ms.

Thank you for your feedback.

The unit of interval_probe_time_ms is milliseconds, 
which is user-friendly. Internally in the kernel, it is actually converted 
to jiffies. Using NEIGH_VAR_INTERVAL_PROBE_TIME to match jiffies makes the 
code more readable and developer-friendly.

>>
>> Using NEIGH_VAR_INTERVAL_PROBE_TIME is a better naming choice.
>>
>> Fixes: bf48c3fae6d7 ("Merge branch 'net-neigh-introduce-interval_probe_time-for-periodic-probe'")
>
>Do not carry Fixes tag since it's not a fix. On the other hand, it is a 
>merge commit not a regular commit...

I will remove the tag in PATCH v2.