Re: [PATCH v3 01/11] iomap: introduce IOMAP_F_ZERO_TAIL flag
From: Namjae Jeon
Date: Fri May 15 2026 - 01:53:31 EST
On Fri, May 15, 2026 at 1:48 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> > +++ b/fs/iomap/buffered-io.c
> > @@ -837,6 +837,7 @@ static int __iomap_write_begin(const struct iomap_iter *iter,
> > folio_zero_segments(folio, poff, from, to, poff + plen);
> > } else {
> > int status;
> > + const struct iomap *iomap = iomap_iter_srcmap(iter);
>
> Please keep variables initialized at declaration time above those that
> are not.
Okay, I will fix it in the next version.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Thanks for the review!