Re: [PATCH v3 1/5] hwmon: (pmbus/adm1266) add firmware_revision debugfs entry

From: Abdurrahman Hussain

Date: Fri May 15 2026 - 02:00:04 EST


On Thu May 14, 2026 at 9:48 PM PDT, Guenter Roeck wrote:
> My understanding is that there is no in-kernel API to inform drivers
> about a rtc update. No other driver seems to need this.
> I see a number of options:
>
> 1) Use ktime_get_real_seconds() in probe, just like every other Linux
> driver using the real time clock does without problems.
> 2) schedule a timer which updates the clock every hour ? day ?
> 3) Attach a sysfs attribute to the i2c device to trigger a time sync.
>
> 2) and 3) are a bit excessive, so you'll need to provide a specific
> use case. "Because the datasheet says so" is not a use case.
>

Going with option 1. The current ktime_get_seconds() seed is
CLOCK_MONOTONIC, so this is a bug fix in disguise -- I'll land the
ktime_get_real_seconds() switch in the pre-existing fix series with
a Fixes: tag.

Thanks,
Abdurrahman