Re: [PATCH v4 1/3] drm/bridge: ite-it66121: Switch to the HDMI connector helpers

From: Javier Martinez Canillas

Date: Fri May 15 2026 - 05:50:08 EST


Maxime Ripard <mripard@xxxxxxxxxx> writes:

Hello Maxime,

> On Fri, May 15, 2026 at 11:02:09AM +0200, Javier Martinez Canillas wrote:

[...]

>> +static int it66121_bridge_hdmi_write_hdmi_infoframe(struct drm_bridge *bridge,
>> + const u8 *buffer, size_t len)
>> +{
>> + return 0;
>> +}
>> +
>
> When the code says it's mandatory, it means "it needs to be implemented" ;)
>

Fair. The driver currently is only implenting AVI infoframes, but I agree
that needs to implement these too. I'll tackle that in the next iteration.

> Looks good otherwise

Thanks again for all your feedback and patience reviewing this series.

> Maxime

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat