Re: [PATCH 2/3] spi: dw-mmio: Add LECARC ACPI ID and init hook

[Andy Shevchenko]

On Thu, May 14, 2026 at 10:40:11AM +0800, thomas wrote:
> Add ACPI ID "LECA0002" for LECARC SoCs. This ID requires a custom
> initialization function dw_spi_lecarc_init() that sets dws->dws.ip
> to DW_HSSI_ID.
> 
> Also add corresponding ACPI description in acpi_apd.c.

...

>  	{ "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) },
>  	{ "HISI0173", APD_ADDR(hip08_spi_desc) },
>  	{ "NXP0001", APD_ADDR(nxp_i2c_desc) },
> +	{ "LECA0002", APD_ADDR(leca_spi_desc) },

Keep them ordered or close enough to be ordered. Id est in this case
locate it before NXP.

...

> +static int dw_spi_lecarc_init(struct platform_device *pdev,
> +			     struct dw_spi_mmio *dwsmmio)
> +{
> +	dwsmmio->dws.ip = DW_HSSI_ID;
> +
> +	return 0;
> +}

dw_spi_intel_init() is the same, why not reusing it?

Note, if uncomfortable with the name, make a patch to rename it to something like
dw_spi_hssi_no_dma_init().

-- 
With Best Regards,
Andy Shevchenko