Re: [PATCH v5 08/14] media: iris: Rename clock and power domain macros to use vcodec prefix

From: Dmitry Baryshkov

Date: Fri May 15 2026 - 06:43:13 EST


On Thu, May 14, 2026 at 11:15:39AM +0200, Konrad Dybcio wrote:
> On 5/13/26 3:47 PM, Dmitry Baryshkov wrote:
> > On Sat, May 09, 2026 at 10:37:20PM +0530, Vishnu Reddy wrote:
> >>
> >> On 5/9/2026 1:52 AM, Dmitry Baryshkov wrote:
> >>> On Sat, May 09, 2026 at 12:29:57AM +0530, Vishnu Reddy wrote:
> >>>> The current clock and power domain enum names are too generic. Rename
> >>>> them with a vcodec prefix to make the names more meaningful and to easily
> >>>> accommodate vcodec1 enums for the secondary core for glymur platform.
> >>>>
> >>>> No functional changes intended.
> >>>>
> >>>> Reviewed-by: Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>
> >>>> Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> >>>> ---
>
> [...]
>
> >>>> IRIS_CTRL_FREERUN_CLK,
> >>>> - IRIS_HW_FREERUN_CLK,
> >>>> + IRIS_VCODEC_FREERUN_CLK,
> >>> Can we at least group them too?
> >>>
> >>>> IRIS_BSE_HW_CLK,
> >>> Is BSE a core or a codec clock?
> >
> > Unanswered
>
> Is it the same BSE that requires a new clock on Purwa?
>
> https://lore.kernel.org/linux-arm-msm/20260507-enable_iris_on_purwa-v6-2-48da505e23bf@xxxxxxxxxxxxxxxx/

Yes. But not that BSE question is simply an attempt to find a better
approach for naming the clocks.

--
With best wishes
Dmitry