Re: [PATCH v2 1/3] dt-bindings: crypto: qcom,ice: Add sa8255p support

[Krzysztof Kozlowski]

On 15/05/2026 15:23, Linlin Zhang wrote:
> 
> 
> On 5/14/2026 8:55 PM, Krzysztof Kozlowski wrote:
>> On Mon, May 11, 2026 at 08:37:48PM -0700, Linlin Zhang wrote:
>>> On sa8255p, resources such as PHY, clocks, regulators, and resets are
>>> managed by remote firmware via the SCMI power protocol. As a result, the
>>> ICE driver cannot directly access clocks and must instead use power-domains
>>> to request resource configuration.
>>
>> Then how can it be compatible with qcom,inline-crypto-engine?
> 
> Thanks for the review.
> 
> You are right that the SCMI-based implementation differs from the
> traditional inline crypto engine in terms of resource control. On
> sa8255p, clocks and other resources are managed by remote firmware
> via SCMI, so the driver does not directly control these resources
> and instead relies on power domains.
> 
> Given this difference, the SCMI variant does not match the same
> programming model as the existing qcom,inline-crypto-engine
> implementation. Using it as a generic fallback is therefore not
> appropriate, as the generic compatible implies that the device can
> be handled equivalently by the same driver assumptions, which is
> not the case here.

Are you pasting here LLM responses? Two long paragraphs, written in over
formal English with no grammar errors and repeating standard AI slop
answer - "You are right".

Sending me LLM responses or LLM patches is unfortunately straight way to
get ignored.

Best regards,
Krzysztof