Re: [PATCH v2] arm64: dts: ti: k3-j784s4: Add GPU node

[Nishanth Menon]

On 15:18-20260506, Antonios Christidis wrote:
> Add the Series BXS GPU node for j784s4 device tree.
> 

Adding documentation why j721s2 compatible is correct for j784s4 is
needed.

[...]
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index 78fcd0c40abc..ddb9385cd942 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -137,6 +137,20 @@ serdes2: serdes@5020000 {
>  		};
>  	};
>  
> +	gpu: gpu@4e20000000 {


https://docs.kernel.org/devicetree/bindings/dts-coding-style.html

"Nodes on any bus, thus using unit addresses for children, shall be
ordered by unit address in ascending order. Alternatively for some
subarchitectures, nodes of the same type can be grouped together,
e.g. all I2C controllers one after another even if this breaks unit
address ordering."

Any specific reason to keep this patch ordering?

> +		compatible = "ti,j721s2-gpu", "img,img-bxs-4-64", "img,img-rogue";

^^ j721s2-gpu: please clarify in commit message.

[...]

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource