Re: [PATCH v2] maple_tree: document that "last" in mtree_insert_range() is inclusive

[Liam R. Howlett]

On 26/05/14 07:23AM, SeongJae Park wrote:
> On Thu, 14 May 2026 10:07:23 -0400 Steven Rostedt <rostedt@xxxxxxxxxx> wrote:
> 
> > On Wed, 13 May 2026 18:42:04 -0700
> > SeongJae Park <sj@xxxxxxxxxx> wrote:
> > 
> > > >  /**
> > > > - * mtree_insert_range() - Insert an entry at a given range if there is no value.
> > > > + * mtree_insert_range() - Insert an entry from [first, last] at a given range
> > > > + *                        if there is no value.  
> > > 
> > > It feels "at a given range" bit repetitive to me.  s/at a given range// ?
> > > 
> > 
> > I just added what Liam suggested.
> 
> Liam's suggestion was very sligtly different.
> 
> : Something like this:
> :
> : mtree_insert_range() - Insert an entry from [first, last] if there isn't
> : an entry within that range.
> 
> So I assumed you intentionally reworded it, but might forgot erasing 'at a
> given range'.  English is never my mother tongue language, but Geminit also
> told me dropping 'at a given range' makes it bit easier to read.  Hence I just
> wanted to check if this is intentional.
> 
> > Should I send a v3?
> 
> The current wording works for me.  English is never my mother tongue langauage,
> so I cannot judge.  I just wanted to make sure this is the intended change.  So
> I will leave the decision to you and others.
> 
> If we decide to rewording, I think Andrew could help without asking you to
> resned v3 for such a minor change.
> 

I'm happy with what we have.  Steven, since it wasn't clear to you
before maybe you can say if it's clear now?

I think I'll have to look through the rest of the function documentation
to align to what we've decided here.

Thanks,
Liam